Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect modified migration scripts #155

Closed
felixkrull-neuland opened this issue Sep 16, 2022 · 1 comment · Fixed by #156
Closed

Detect modified migration scripts #155

felixkrull-neuland opened this issue Sep 16, 2022 · 1 comment · Fixed by #156
Assignees
@xtermi2
Labels
enhancement New feature or request

Comments

@felixkrull-neuland
Copy link
Contributor

When comparing the local migration scripts with the record of already the executed scripts, the library should be able to detect if an already-executed script was modified afterwards, and raise an error. Given that checksums of the scripts are calculated and stored, I was surprised that this wasn't already being checked. I'm not that familiar with Flyway, but the Play Framework's evolutions module does verify the checksum.

Is this an intentional design choice? If not, I'd change it and open a PR.
@felixkrull-neuland felixkrull-neuland mentioned this issue Sep 19, 2022
Merged
@xtermi2 xtermi2 self-assigned this Oct 3, 2022
@xtermi2 xtermi2 added the enhancement New feature or request label Oct 3, 2022
@xtermi2 xtermi2 linked a pull request Oct 11, 2022 that will close this issue
Disallow changes to previously successfully applied scripts #156
Merged
@xtermi2
Copy link
Collaborator

xtermi2 commented Jan 11, 2023

fixed with v0.4.1

@xtermi2 xtermi2 closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xtermi2 xtermi2

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@xtermi2 @felixkrull-neuland