Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Styling of Navigation Portlet #100

Merged
merged 2 commits into from Mar 29, 2019
Merged

Improve Styling of Navigation Portlet #100

merged 2 commits into from Mar 29, 2019

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR improves the appearance of the navigation portlet for desktop/mobile devices

Current behavior before PR

  • blurry icons on high-res displays (4K and above)
  • No padding of items in mobile view
  • submenu overflow

Desired behavior after PR is merged

  • crisp icons for high-res displays
  • propper item padding in mobile view
  • submenu items do not break after the icon and overflow with ellipsis

--
I confirm I have tested the PR thoroughly and coded it according to PEP8
standards.

@ramonski ramonski requested a review from xispa March 29, 2019 12:04
@ramonski
Copy link
Contributor Author

Default appearance

SENAITE 2019-03-29 13-05-59

Default with submenu

Analysis Categories — SENAITE 2019-03-29 13-08-26

Mobile appearance

SENAITE 2019-03-29 13-06-59

Mobile with submenu

Analysis Categories — SENAITE 2019-03-29 13-07-43

@xispa xispa merged commit be0f81f into master Mar 29, 2019
@xispa xispa deleted the improved-nav-portlet branch March 29, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xispa xispa xispa approved these changes

Assignees
No one assigned
Labels
Enhancement
Milestone
No milestone
2 participants
@ramonski @xispa