Should 'timeout' middleware be cleared if client drops connection?

[jkirkwood]

I recently stumbled across this observation with the timeout middleware:

If a client makes a request, but closes the connection before the server has a chance to respond, the timeout still expires after the allotted amount of time, and an error occurs.

For the sake of preventing irrelevant errors from being populated in log files, I'm wondering if request timeouts should be cleared if the connection is closed. For the time-being I've added the following before the 'timeout' middleware.

app.use(function(req, res, next) {
  res.on('close', function() {
    req.clearTimeout();
  });
  next();
});

[dougwilson]

Hi! There is no source for timeout middleware in here, so there is nothing that can be done in this project. Please file the issue at connect-timeout library. Also, yes, it should be cleared.

[jkirkwood]

Missed that. Thanks!

[dougwilson]

No problem. I look forward to seeing your new issue.