session.id not initialized properly

[canoeberry]

If your browser comes in with a session cookie, but that cookie is long gone (you restarted the server and were using memory cookies), a new session object is created where

req.session.id = <old cookie from browser>
req.sessionID = <new ID that should have been stored in session.id>

That's because the generate() function looks like this:

    var generate = store.generate = function(){
        var base = utils.uid();
        var sessionID = base + "." + hash(base);
        req.session = new Session(req, sessionID);
        req.sessionID = sessionID;
    };

and passing in sessionID to the Session constructor does nothing with sessionID because it's not an object. The Session constructor initializes session.id with req.sessionID, but generate doesn't set req.sessionID until after the Session constructor.

[tj]

Fixed session.id issue. Closed by 7840744