Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test to check some files #59

Merged
merged 6 commits into from Nov 22, 2017
Merged

Conversation

gabrielclima
Copy link
Contributor

Fixes #52

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Create test to check some repo files

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017

CLA assistant check
All committers have signed the CLA.

@gabrielclima
Copy link
Contributor Author

Missing files:

  • docker/Docker
  • docker/docker-compose.yml
  • .codeclimate.yml
  • LICENSE.md
  • USE_CASES.md

image

Travis CI log : travis-ci.org/sendgrid/rest/jobs/294564675

@thinkingserious
Copy link
Contributor

@gabrielclima

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@gabrielclima
Copy link
Contributor Author

@thinkingserious thank you and @sendgrid for love community! <3

@mbernier mbernier added the difficulty: medium fix is medium in difficulty label Nov 17, 2017
@mbernier
Copy link
Contributor

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@gabrielclima
Copy link
Contributor Author

@mbernier it would be a honor!
thank you for the oportunity, but my english is still bad to a live talk hehehe
i followed you on twitter and i'll talk to you via email eventually :)

@mbernier
Copy link
Contributor

@gabrielclima my email is my github user at my company's domain - hit me up, I am more than happy to communicate over email.

@mbernier mbernier merged commit 68fc260 into sendgrid:master Nov 22, 2017
@thinkingserious
Copy link
Contributor

Hello @gabrielclima,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
4 participants