Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure sendgrid-php does not use sslv3 #111

Closed
nquinlan opened this issue Oct 24, 2014 · 6 comments
Closed

ensure sendgrid-php does not use sslv3 #111

nquinlan opened this issue Oct 24, 2014 · 6 comments

Comments

@nquinlan
Copy link
Contributor

PHP automatically tries to use SSLv3 when connecting to SendGrid however that no longer works as we disabled support for SSLv3 due to POODLE this can result is failures. We should ensure we don't try to use SSLv3 with this lib.

@nquinlan
Copy link
Contributor Author

The following solves the problem, although it's likely not the most elegant solution.

curl_setopt($curl, CURLOPT_SSLVERSION, CURL_SSLVERSION_TLSv1_2);

@nquinlan
Copy link
Contributor Author

@elbuo8 @eddiezane @kunal732 any chance y'all can look into this?

@eddiezane
Copy link
Contributor

Added it to my list unless someone else gets to it first.

@iansltx
Copy link

iansltx commented Oct 30, 2014

While I'm here...

Looks like Unirest doesn't support injecting custom curl parameters into its requests. Would be easy enough to add something similar to what they already do here:

https://github.com/Mashape/unirest-php/blob/master/lib/Unirest/Unirest.php#L207

to turn off SSLv3 support.

@nquinlan
Copy link
Contributor Author

Yeah, probably worth a PR.

@eddiezane
Copy link
Contributor

We do not support sslv3 on the API anymore, so this should no longer be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants