Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGES #290

Closed
thinkingserious opened this issue Sep 12, 2016 · 6 comments
Closed

BREAKING CHANGES #290

thinkingserious opened this issue Sep 12, 2016 · 6 comments
Labels
status: help wanted requesting help from the community type: question question directed at the library

Comments

@thinkingserious
Copy link
Contributor

As a result of your feedback and as a continuation of the execution of our long term roadmap, there will be breaking changes coming soon. The last time we had a major breaking change, it was for the implementation of v3 Web API support. We announced those changes here on GitHub along with some instructions on how to test and provide feedback.

The feedback we got was amazing, but we didn't quite get the amount or thoroughness of feedback we were hoping for.

We want to continue improving this iterative process, so we are reaching out to you for feedback in order to determine the optimum way to move forward as this library is designed to be community driven, SendGrid led.

Please take a moment to share your thoughts with us.

Following are some ideas we are considering, we will likely choose one from Execution and one from Communication, but not all of the items below.

Execution (for large changes):

  1. Utilize the pre-release functionality in GitHub to gather feedback and contributions to a specific branch
  2. Communicate through a dedicated GitHub issue that references that pre-release branch (e.g C# Dynamic Update)

Communication:

  1. Continue using GitHub issues
  2. Opt-in email newsletter for announcements
  3. Opt-in email mailing list
  4. Dedicated social media account (e.g. @sendgrid_libraries)

How do you prefer to get these announcements? Is this too much? Too little? Please let us know!!

As always, we are listening carefully and are looking forward to working with you.

Note: We will always follow the semver.org convention of using major point releases to signify breaking changes. Please DO NOT auto-update your dependencies. It is important to take a look at the CHANGELOG or releases to find out how the breaking changes will impact your code.

@thinkingserious thinkingserious added type: question question directed at the library status: help wanted requesting help from the community labels Sep 12, 2016
@ninsuo
Copy link
Contributor

ninsuo commented Oct 10, 2016

As far as I can see in 5.0.4, we cannot set any curl option in the client.
This is a big lack of flexibility.
This broken #149 and #157

@thinkingserious
Copy link
Contributor Author

@ninsuo,

Thanks, that is great feedback!

I'm thinking the change would go here: https://github.com/sendgrid/php-http-client/blob/master/lib/Client.php#L42

Would you like to give it a shot with a PR, or would you like us to create a ticket for a fix?

With Best Regards,

Elmer

@ninsuo
Copy link
Contributor

ninsuo commented Oct 10, 2016

Yep, we need this quickly and your implementation is quite simple, so I will open a PR tomorrow.

Thanks,

@thinkingserious
Copy link
Contributor Author

Awesome, thank you @ninsuo!

@lode
Copy link

lode commented Oct 15, 2016

I would like Execution 2 (although I prefer 1 but GitHub notifications don't work well along with that) and Communication 2.

Is that the kind of feedback you're looking for?

@thinkingserious
Copy link
Contributor Author

Yes, thanks @lode!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: question question directed at the library
Projects
None yet
Development

No branches or pull requests

3 participants