-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGES #290
Comments
Thanks, that is great feedback! I'm thinking the change would go here: https://github.com/sendgrid/php-http-client/blob/master/lib/Client.php#L42 Would you like to give it a shot with a PR, or would you like us to create a ticket for a fix? With Best Regards, Elmer |
Yep, we need this quickly and your implementation is quite simple, so I will open a PR tomorrow. Thanks, |
Awesome, thank you @ninsuo! |
I would like Execution 2 (although I prefer 1 but GitHub notifications don't work well along with that) and Communication 2. Is that the kind of feedback you're looking for? |
Yes, thanks @lode! |
As a result of your feedback and as a continuation of the execution of our long term roadmap, there will be breaking changes coming soon. The last time we had a major breaking change, it was for the implementation of v3 Web API support. We announced those changes here on GitHub along with some instructions on how to test and provide feedback.
The feedback we got was amazing, but we didn't quite get the amount or thoroughness of feedback we were hoping for.
We want to continue improving this iterative process, so we are reaching out to you for feedback in order to determine the optimum way to move forward as this library is designed to be community driven, SendGrid led.
Please take a moment to share your thoughts with us.
Following are some ideas we are considering, we will likely choose one from Execution and one from Communication, but not all of the items below.
Execution (for large changes):
Communication:
How do you prefer to get these announcements? Is this too much? Too little? Please let us know!!
As always, we are listening carefully and are looking forward to working with you.
Note: We will always follow the semver.org convention of using major point releases to signify breaking changes. Please DO NOT auto-update your dependencies. It is important to take a look at the CHANGELOG or releases to find out how the breaking changes will impact your code.
The text was updated successfully, but these errors were encountered: