New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding events consumer which provides an example of working with email events #660
Conversation
Codecov Report
@@ Coverage Diff @@
## v4 #660 +/- ##
=======================================
Coverage 84.35% 84.35%
=======================================
Files 36 36
Lines 965 965
Branches 107 107
=======================================
Hits 814 814
Misses 93 93
Partials 58 58 Continue to review full report at Codecov.
|
Hello @Taiters, |
ce19112
to
ae3ab76
Compare
Hey @thinkingserious, I've added my latest changes (docs and a slightly easier way to view events) and updated the base branch to Let me know if anything else needs added. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except I think events/data/events.db
should not be part of the PR.
dc0b6da
to
78401a8
Compare
78401a8
to
181658d
Compare
Yeah well spotted @misterdorm! I've removed that folder from the PR |
events/test.py
Outdated
def read_events(): | ||
with open('sample_data.json', 'r') as f: | ||
body = f.read() | ||
return json.loads(body) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this what json.load
is for?
with open('sample_data.json', 'r') as f:
return json.load(f)
Hello @Taiters, |
Hey, I've noticed this PR still has the WIP label. It's no longer a WIP :) |
Resolves #649
Checklist
Short description of what this PR does:
This PR adds
This repo already contains a Procfile for the email ingress example, so I've suggested copying the
events/
dir into a new repo on the users computer as part of the Heroku deploy to keep them separate.