empty result instead of timeout

[ro70]

A load$ query to a non-existing entity ends up in a timeout. It should better return an empty object {}, shouldn't it?

[mcdonnelldean]

@ro70 Agreed. @mihaidma @mirceaalexandru @geek Thoughts on this?

[mirceaalexandru]

I think that we should return error because we should signal that there is setup issue, not just that there is not a matching entity in DB.

We should also check what is the behavior of the drivers we are using for each DB engine, as one can return error, others can return {}, so might not have a consistent API across our stores.

This problem do not exist for MongoDb as it will just create the collection if necessary, but for Postgres/Mysql there is another case, there should be created manually - but I don't know the response from their drivers for this scenario.

[mirceaalexandru]

@ro70 I understood that this problem appear when the table do not exists yes?

[mihaidma]

The spec for this case is this: https://github.com/senecajs/seneca-store-test/blob/master/store-test.js#L111
return null for non existing entity

@mirceaalexandru let's open a discussion about returned value for list and load when nothing matches.
I'll let this issue open to investigate the timeout, it shouldn't give timeout. I'll get to it in the next few days as I am currently working on mysql store.

[ro70]

@mirceaalexandru , @mihaidma The table does exist. Imagine the following use case: There's a table 'PlayersPoints' with the fields 'id', 'player_id' and 'points'. As long as a player has zero points, there's no entity with its player_id. If I'd like to know how many points a specific player has, I do playerEntity.load$({player_id: id}...). The resulting set may be empty (or null if you want). It even is alright to throw a (nothing found) error in this case, but waiting for a timeout is not the best solution in my opinion.

[mirceaalexandru]

@ro70 , sorry I understood that table do not exists, my comment was for that scenario.

In this case the result should be null in my opinion, and timeout is a bug that needs to be fixed.