Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web timeout vs http timeout #148

Open
blueshirts opened this issue Jan 11, 2017 · 0 comments
Open

web timeout vs http timeout #148

blueshirts opened this issue Jan 11, 2017 · 0 comments
Assignees
Labels

Comments

@blueshirts
Copy link

blueshirts commented Jan 11, 2017

Similar to some of the examples in the README if you want to specify a top level timeout for http it seems like it must be labeled as web. The code below doesn't seem to do anything. If I change to transport name key from http to web it does seem to use the settings.

    var seneca = require('seneca')
    seneca({
        transport:{
          http:{
            timeout:500
          }
       }
    })

In the transport source I see the defaults listed under the web attribute also. Seems like http is an alias though does not work when it comes to settings. If I am correct this can be somewhat confusing. It would be nice if either http or web was used or the alias worked for all cases.

web: {
      type: 'web',
      port: 10101,
      host: '0.0.0.0',
      path: '/act',
      protocol: 'http',
      timeout: 5555,
      max_listen_attempts: 11,
      attempt_delay: 222,
      serverOptions: {}
},
@rjrodger rjrodger self-assigned this Feb 16, 2019
@rjrodger rjrodger added the bug label Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants