Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"When" column should be renamed for compat #51

Closed
Wardormeur opened this issue Jun 25, 2016 · 5 comments
Closed

"When" column should be renamed for compat #51

Wardormeur opened this issue Jun 25, 2016 · 5 comments

Comments

@Wardormeur
Copy link
Member

"when" column seems to break seneca-sqlite-store.
Considering "when" is a reserved SQL keyword, another name would be welcome to avoid such issue :)

@indr
Copy link

indr commented Jul 29, 2016

What about... createdAt, modifiedAt... or even better.... createdAtUtc, modifiedAtUtc etc.

@mcdonnelldean
Copy link
Contributor

Is this coming from entity or specifically from seneca-user? I agree with @indr's suggestions. Thoughts @mihaidma

@augustine-tran
Copy link

+1
I got the same with PostgreSQL

@mihaidma
Copy link
Contributor

the seneca-sqlite-store needs to have its code replaced with the seneca-standard-store plugin. This is used by both postgres and mysql. All store fixes will go now into the standard-store plugin as it fixes all stores.

@mihaidma
Copy link
Contributor

mihaidma commented Aug 23, 2016

I'll close this and open an issue on both standard-store and sqlite store. I think this is more like a bug related to escaping the column names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants