3.0 Test and Repo Pretidy #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
1 similar comment
- already in seneca-repl - seneca-repl is checked against seneca via travis
- put stubs in stubs folder, - flattened out *.tests.js files to make it easier to find them - removed tests that are testing non default plugins - removed all code from test folder that is not for testing purposes - various changes to support the above
1 similar comment
2 similar comments
|
@mihaidma can you throw a quick eye over this before I merge? In case I missed anything? |
| // Output | ||
| // null { tag: 'none' } | ||
| // null { tag: 'approver' } | ||
| // null { tag: 'rejector' } | ||
| ``` |
There was a problem hiding this comment.
ran the sample and got:
null { tag: 'local' }
null { tag: 'approver' }
null { tag: 'rejector' }
| 8. Run `npm publish` | ||
| 9. Run `npm tag seneca@VERSION next` | ||
| 10. Run `npm tag seneca@VERSION plugin` | ||
| 11. Update and publish plugins |
There was a problem hiding this comment.
one more step needed:
go to https://github.com/senecajs/seneca/releases
Push the Draft a new release button and paste there the Changelog content. Choose the tag version and a title.
There was a problem hiding this comment.
@mihaidma I actually want to talk about this file today with you. We need to add the above plus steps on running the rig.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to tidy the test suite and related structure before 3.0 launches.
Changes
/docs/docs@rjrodger You may want to throw an eye over this. Bear in mind two points. We are going to be testing all SenecaJs plugins via The Rig post 3.0 and we are fixing documentation so are looking to remove all of the out of date examples from the repos.