Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License of the project #1

Open
pazos opened this issue Jan 12, 2020 · 3 comments
Open

License of the project #1

pazos opened this issue Jan 12, 2020 · 3 comments

Comments

@pazos
Copy link

pazos commented Jan 12, 2020

Hi @sengjea, I have two questions:

  1. is this project opensource? license?
  2. (if opensource) are you willing to accept pull requests?

If the program is opensource I would like to update it to work with recent android studio tools and recent android apis and to release it on F-Droid.

Thanks for your time!!!!

@sengjea
Copy link
Owner

sengjea commented May 5, 2020

Hi yes, it is open source and happy to accept PRs.

@pazos
Copy link
Author

pazos commented May 5, 2020

Cool! These days I'm too busy but I'll try to spend some time in the next weeks!!

@pazos
Copy link
Author

pazos commented May 7, 2020

@sengjea: minimal changes to build with recent Android Studio and gradle plugins are staged in pazos@bb46557.

Didn't touch your code yet, so there's a few reasons to stay on lower API levels:

  1. Avoid runtime permissions (needed on API 23+)
  2. Avoid implementing a file provider and still pass a file uri (which triggers an exception on API 24+)

I would like your feedback about these two things.

For the first one we don't need storage RW permission if we implement storage on top of SAF: current "root" folder would be on the internal storage of the app and used as a cache and thus removed when the app is removed. The other way is stay legacy: ask for storage permission on activity onCreate and be limited to the primary storage to choose the "root" folder.

About the second issue: I would like to implement a switachable option, to allow users to feed both file and content uris to other apps. So newer, sandboxed, apps will probably need "content" to work with - and importing files, making a hard copy. Legacy apps can work fine with file uris as long as they have their own storage permissions too.

Waiting for your reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants