deprecation warning when BufferedLogger is instantiated

senny · Dec 25, 2012 · 8787c6e · 8787c6e
1 parent 95fa0e6
commit 8787c6e
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/activesupport/lib/active_support/buffered_logger.rb b/activesupport/lib/active_support/buffered_logger.rb
@@ -3,9 +3,19 @@
 
 module ActiveSupport
   class BufferedLogger < Logger
+
+    def initialize(*args)
+      self.class._deprecation_warning
+      super
+    end
+
     def self.inherited(*)
-      ::ActiveSupport::Deprecation.warn 'ActiveSupport::BufferedLogger is deprecated! Use ActiveSupport::Logger instead.'
+      _deprecation_warning
       super
     end
+
+    def self._deprecation_warning
+      ::ActiveSupport::Deprecation.warn 'ActiveSupport::BufferedLogger is deprecated! Use ActiveSupport::Logger instead.'
+    end
   end
 end
diff --git a/activesupport/test/deprecation/buffered_logger_test.rb b/activesupport/test/deprecation/buffered_logger_test.rb
@@ -11,4 +11,12 @@ def test_can_be_subclassed
     Class.new(ActiveSupport::BufferedLogger)
   end
 
+  def test_issues_deprecation_when_instantiated
+    warn = 'ActiveSupport::BufferedLogger is deprecated! Use ActiveSupport::Logger instead.'
+
+    ActiveSupport::Deprecation.expects(:warn).with(warn).once
+
+    ActiveSupport::BufferedLogger.new(STDOUT)
+  end
+
 end