Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement different error messages for unknown HTML tags and invalid tag placement #66

Closed
stadelmanma opened this issue Aug 1, 2017 · 0 comments

Comments

@stadelmanma
Copy link
Collaborator

This arises from #65 where it is not clear when the end user is using an unknown tag, a valid tag in an invalid way (i.e. <i></i> outside of a paragraph or div). A better route is to create a separate error message when the structure itself is invalid but the tag is supported.

Currently the code handles Runs and Paragraphs separately validating the structure as it loops through nodes. Depending on eventual refactors from #62 and/or #48 if we choose to implement inline HTML replacement that may not be the most effective and/or logical way. A separate method to check the final AST structure produced may be better in terms of future code flexibility.

@stadelmanma stadelmanma self-assigned this Aug 4, 2017
@stadelmanma stadelmanma mentioned this issue Aug 4, 2017
7 tasks
@stadelmanma stadelmanma moved this from To Do to In Progress in Expand HTML Parsing Aug 4, 2017
@stadelmanma stadelmanma moved this from In Progress to Done in Expand HTML Parsing Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant