Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Box3 #178

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Upgrade to Box3 #178

merged 1 commit into from
Oct 9, 2018

Conversation

theofidry
Copy link
Contributor

I'm actually not sure if you were using Box 2 or Box 3, but in any case the following works with Box 3.1.

List of the changes:

  • Simplify the box.json.dist config by removing the redundant settings stub and output
  • Remove the directories setting of the box.json.dist config allowing Box to do the auto-discovery of the files to include. This allows Box to easily remove the dev dependencies so there is no longer a need to do a composer install --no-dev
  • Simplify the make build
    • Remove the unnecessary chmod +x since the generated PHAR is already an executable
    • Remove the now unnecessary composer install --no-dev
    • Rename box build to box compile (the previous command name has been deprecated)
  • Add the files generated by make build to .gitignore

@timglabisch
Copy link
Collaborator

thanks.

@timglabisch timglabisch merged commit f4deac7 into qossmic:master Oct 9, 2018
@theofidry theofidry deleted the feature/box3 branch October 9, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants