You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #14, adaptive thresholds were introduced, which modify the actual warning and critical thresholds according to a "magic factor". This is very useful, but I think the calculation in the code is wrong.
There is a formula in the description:
y = 100 - (100-P)*(N^(1-m))/(x^(1-m))
According to this formula, a threshold of 75% for a disk of 400GB (normalization factor 50 and magic number 0.8) should be raised to ~83.5%:
y = 100 - (100-75)*(50^(1-0.8))/(400^(1-0.8)) = ~83.50
But actually it is raised to ~95.9%, which is way too high.
In #14, adaptive thresholds were introduced, which modify the actual warning and critical thresholds according to a "magic factor". This is very useful, but I think the calculation in the code is wrong.
There is a formula in the description:
According to this formula, a threshold of 75% for a disk of 400GB (normalization factor 50 and magic number 0.8) should be raised to ~83.5%:
But actually it is raised to ~95.9%, which is way too high.
My suspicion is, that there is a confusion of units in the following line:
https://github.com/sensu-plugins/sensu-plugins-disk-checks/blob/master/bin/check-disk-usage.rb#L144
The disk size in bytes passed to
adj_percent
is converted to mebibytes instead of gibibytes. I think it should be divided by1024**3
instead.I stumbled upon this because we were alerted of a shortage in disk space later than we expected. Can anyone confirm this issue?
The text was updated successfully, but these errors were encountered: