Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcc required due to vmstat add_runtime_dependency #22

Closed
jpcarey opened this issue Nov 5, 2015 · 8 comments
Closed

gcc required due to vmstat add_runtime_dependency #22

jpcarey opened this issue Nov 5, 2015 · 8 comments

Comments

@jpcarey
Copy link

jpcarey commented Nov 5, 2015

the add_runtime_dependency for vmstat requires that the system this gem will be deployed to must have a gcc compiler in order to compile the vmstat binary. This is an annoying dependency, and is required even if the vmstat package is available on the system.

https://github.com/sensu-plugins/sensu-plugins-memory-checks/blob/master/sensu-plugins-memory-checks.gemspec#L44

@analytically
Copy link
Contributor

@mattyjones

@mattyjones
Copy link
Member

@jpcarey @analytically Sorry for the late response. I agree with it being a pia, and would be open to pulling it if a better solution is known otherwise I am not sure what the best course of action is.

@confiq
Copy link

confiq commented Feb 3, 2016

It's kinda problematic dependency...
Perhaps moving vmstat to different plugin might be right solution?

apt-get install build-essential in debian will enable installing memory-checks plugin...

@analytically
Copy link
Contributor

I'll accept a PR removing the dependency and detailing the vmstat installation for check-ram.rb. Would it also be possible to add a check to check-ram.rb?

@majormoses
Copy link
Member

@analytically sorry I must have missed the email. I have yet to find a better solution with a ruby implementation and I dont think we can get around that. What I suppose we could do is make it a development dependency, add a check to the plugin, and detail the unique install instructions...

@analytically
Copy link
Contributor

Sounds good! And add explanation in CAPITAL in plugin description...

@majormoses
Copy link
Member

#25

@majormoses
Copy link
Member

@jpcarey let me know if the pr fixes your issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants