Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Multi-build config should not have header attributes #221

Closed
jspaleta opened this issue Sep 9, 2019 · 1 comment
Closed

Bug: Multi-build config should not have header attributes #221

jspaleta opened this issue Sep 9, 2019 · 1 comment

Comments

@jspaleta
Copy link

jspaleta commented Sep 9, 2019

the multi-build api endpoint is producing json that is include the headers attribute for each build.
This should not be included by default in our public community bonsai.

This might be a ruby or rails internal variable associated with the http session leaking into the config being generated.

here's an example of what I'm seeing being populated right now for a build using the API endpoint https://bonsai.sensu.io//api/v1/assets/<user>/<asset>/<version>/release_asset_builds

      {
        "url": "blah blah blah",
        "sha512": "something",
        "filters": [
          "entity.system.os == 'linux'",
          "entity.system.arch == 'amd64'"
        ],
        "headers": {
          "Authorization": "Bearer $TOKEN",
          "X-Forwarded-For": "$CLIENT"
        }
      },

The "headers" attribute shouldn't be there by default.

I would say that unless explicitly defined in the .bonsai.yml, headers should be hidden.

@mbiang
Copy link

mbiang commented Sep 9, 2019

Thanks @jspaleta - I've removed these, and deployed a hotfix with this patch. Thanks!

@mbiang mbiang closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants