Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple check dependency on corev2 cipher suites #23

Closed
asachs01 opened this issue Dec 15, 2022 · 1 comment
Closed

Decouple check dependency on corev2 cipher suites #23

asachs01 opened this issue Dec 15, 2022 · 1 comment

Comments

@asachs01
Copy link

On line https://github.com/sensu/http-checks/blob/master/cmd/http-get/main.go#L136, the check implements some logic that ends up referring back to corev2 cipher suites that are implemented for the backend. This really doesn't make a lot of sense to use those cipher suites when customers/users have needs to monitor sites that may be using older/weaker cipher suites. We should remove this dependency from the plugin.

@asachs01
Copy link
Author

Solved by #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant