Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to use email template functionality in plugin readme #42

Closed
hillaryfraley opened this issue Feb 27, 2020 · 5 comments
Closed

Comments

@hillaryfraley
Copy link

hillaryfraley commented Feb 27, 2020

The plugin readme instructions for the email template should be updated so that users can follow them to implement their own email templates with this plugin.

Context:

Known updates needed:

  • Identify the flags required for users to successfully use the email template.
  • Explain that if you have more than one backend, they must all use the same email template.
@benh57
Copy link

benh57 commented Jun 2, 2020

Is it possible to reference a check annotation in an email template? This seems like the perfect place to store the 'playbook' url.

To keep this relevant to this ticekt perhaps the example could be updated to source the playbook from the annotation, if this is possible, rather than hardcoding? (i tried {{ Check.Annotations.playbook }} but it didnt seem to work)

@nixwiz
Copy link
Contributor

nixwiz commented Jun 2, 2020

@benh57 You're missing the leading period, try {{ .Check.Annotations.playbook }}, that worked for me.

@nixwiz
Copy link
Contributor

nixwiz commented Jan 25, 2021

@hillaryfraley I believe this has been addressed now, can you verify?

@hillaryfraley
Copy link
Author

@nixwiz yes, it looks like everything is addressed.

@nixwiz
Copy link
Contributor

nixwiz commented Jan 25, 2021

@hillaryfraley closing based on that feedback. Thank you!

@nixwiz nixwiz closed this as completed Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants