An updated Asset SHA can fail to display

[portertech]

[portertech]

Bug update, the value is there on a following asset update:

[grepory]

Some kind of input validation is going to be required to make sure that we're not storing invalid checksums / checksums aren't getting set to nil.

[nikkictl]

The asset sha is only failing to display because the updated sha nope is < 7 characters.

sensu-go/cli/commands/asset/list.go

Lines 83 to 86 in 8271404

	if len(asset.Sha512) >= 7 {
	return string(asset.Sha512[0:7])
	}
	return ""

A quick fix would be something like this:

    length := len(asset.Sha512)

    if length >= 7 {
      return string(asset.Sha512[0:7])
    }
    return string(asset.Sha512[0:length])

But Greg (AFK so not @-ing him here) mentioned that we shouldn't be storing invalid checksums (we already validate it cannot be empty). @portertech do you think this proposed solution is sufficient or would you rather we have a more strict checksum validation at the creation of an asset?

[palourde]

IMO we should ensure the SHA512 is 128 characters, otherwise there's no way it's valid.

[nikkictl]

@palourde 👍

sensu-go (master)$ bin/sensuctl asset update sensu-influxdb-handler
? URL: https://github.com/portertech/sensu-plugins-go/releases/download/0.0.1/sensu-check-plugins.tar.gz
? SHA-512 Checksum: nope
Error: SHA-512 checksum must be at least 128 characters