Agent entities can have the same name

[amdprophet]

Two or more agents can share the same entity name.

Expected Behavior

An agent should not be able to connect to a backend if it is using a name that is already in use.

Current Behavior

We do not check if an agent's name is already in use.

Possible Solution

N/A

Steps to Reproduce (for bugs)

1. Start an agent named "agent-1"
2. Start a second agent named "agent-1"

[nikkictl]

To clarify, an agent should not be able to connect to a backend if said backend or any backend is using a name that is already in use? @echlebek @mercul3s perhaps?

[echlebek]

We don't have any kind of agent registry in the backend. We'd have to implement that in order to enforce this invariant.

[nikkictl]

@echlebek Correct, and even if we did, we wouldn't be able to pass it directly to the agent before a connection is established. I was thinking perhaps an api endpoint (since we do have the backend url) to retrieve the id's of all connected agents. That still begs the questions, should it retrieve connected agents to a single backend or all the connected agents in the entire cluster.

[echlebek]

To properly implement this we'll need to guarantee name uniqueness cluster-wide.

I think it should be enough to cancel a connection after its established, if the agent's name already exists in the registry. We won't need an API endpoint.

[nikkictl]

This behavior is in parity with 1.x. After some discussion, we won't be pursing this for 2.x at this time.

[portertech]