Calculator component added #3
Conversation
There was a problem hiding this comment.
Hi @sentayhu19,
Good job so far!
To Highlight! 👏 🟢
✔️ Organized clean code,
✔️ Your app is running free of Linter errors.
There are some issues that you still need to work on to get this project approved, but you are almost there!
Status: Requires Changes ♻️
Check the comments below and under the review.
I will leave these comments here, since they concern files in your repository
- As it is a requirement for this project, "
Delete all the boilerplate from CRA (text, images, styles)", please kindly delete all files that are not related to this project. Checkout yourpublic directoryand delete all files that where created by theCRAthat are not related to this project, as this will make your repository cleaner and less crowded.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
src/App.js
Outdated
| @@ -1,28 +1,8 @@ | |||
| import logo from './logo.svg'; | |||
| import './App.css'; | |||
| import Calculator from './components/Calculator'; | |||
|
|
|||
| function App() { | |||
There was a problem hiding this comment.
- As it is a requirement for this project, "
Use class based components (All components should be class-based)", please kindly change yourApp.jscomponent which is currently afunctional componenttoclass-basedcomponent.
There was a problem hiding this comment.
Hi @sentayhu19,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
To Highlight 💯
- No linters errors ✔️
- Descriptive pull request ✔️
- Descriptive commit messages ✔️
Optional suggestions
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this pull req