Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum python version into the documentation #15

Closed
IITFA opened this issue Apr 12, 2021 · 3 comments · Fixed by #22
Closed

Add minimum python version into the documentation #15

IITFA opened this issue Apr 12, 2021 · 3 comments · Fixed by #22
Labels
documentation Improvements or additions to documentation/wiki
Milestone

Comments

@IITFA
Copy link

IITFA commented Apr 12, 2021

I'm totally new to python scripts and pip, but I did:
pip3 install --user minecraft-mod-manager
(and tried pip2 and pip with same result)

and got this error:
Could not find a version that satisfies the requirement minecraft-mod-manager (from versions: )
No matching distribution found for minecraft-mod-manager

No idea how to fix this. Searching around doesn't seem to have any solutions.

@Senth
Copy link
Owner

Senth commented Apr 12, 2021

Hmm, googled a bit and might've found something. Also tested on my server just to be sure it works.

Which python version do you use? The script requires at least python 3.8. Run: python --version

I probably should add some info about the minimum python version in the readme 🙂

@IITFA
Copy link
Author

IITFA commented Apr 12, 2021

The highest version of python in the stable Debian repos (the distro I'm on is based on Debian stable) is 3.7.3 apparently. Good thing I'm not new to compiling from source. For those not as familiar and are on a Debian stable distro, you could point them to this link:
https://linuxize.com/post/how-to-install-python-3-8-on-debian-10/

Yes, it might be a good idea to note the minimum python version.
EDIT: Might also be good to add some example commands and maybe a "introduction" of sorts. Using just logic to guess what should be done based on the available arguments seems to result in errors, still trying to figure that out.

EDIT2: The error:

Traceback (most recent call last):
File "/home/username/.local/bin/minecraft-mod-manager", line 10, in
sys.exit(main())
File "/home/username/.local/lib/python3.8/site-packages/minecraft_mod_manager/main.py", line 16, in main
installed_mods = DirParser.get_mods()
File "/home/username/.local/lib/python3.8/site-packages/minecraft_mod_manager/dir_parser.py", line 18, in get_mods
mod = DirParser.get_mod_info(file)
File "/home/username/.local/lib/python3.8/site-packages/minecraft_mod_manager/dir_parser.py", line 27, in get_mod_info
with zip.open("fabric.mod.json") as json_file:
File "/usr/local/lib/python3.8/zipfile.py", line 1514, in open
zinfo = self.getinfo(name)
File "/usr/local/lib/python3.8/zipfile.py", line 1441, in getinfo
raise KeyError(
KeyError: "There is no item named 'fabric.mod.json' in the archive"

@Senth Senth added the documentation Improvements or additions to documentation/wiki label Apr 17, 2021
@Senth
Copy link
Owner

Senth commented Apr 17, 2021

Thanks for the suggestions and crash report 🙂 If you find any more in the future, it's better to add them to a new issue. I also don't get any notifications of edits so I can't respond to them as quickly.

Split the edits into two new issues. #16 and #17 🙂

@Senth Senth changed the title Could not find a version that satisfies the requirement minecraft-mod-manager (from versions: ) No matching distribution found for minecraft-mod-manager Add minimum python version into the documentation Apr 17, 2021
@Senth Senth added this to the 0.4.0 milestone Apr 17, 2021
Senth added a commit that referenced this issue Apr 20, 2021
@Senth Senth mentioned this issue Apr 20, 2021
@Senth Senth closed this as completed in #22 Apr 20, 2021
Senth added a commit that referenced this issue Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation/wiki
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants