Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing go tests #135

Closed
senthilrch opened this issue Feb 23, 2022 · 3 comments
Closed

Fix failing go tests #135

senthilrch opened this issue Feb 23, 2022 · 3 comments
Assignees
Labels
enhancement Enhancement to existing feature good first issue Good for newcomers
Milestone

Comments

@senthilrch
Copy link
Owner

(⎈ |olah009:mxe-senthil)eechens@EMB-Q6BUMD6N kube-fledged % pwd
/Users/eechens/Documents/src/github.com/senthilrch/kube-fledged
(⎈ |olah009:mxe-senthil)eechens@EMB-Q6BUMD6N kube-fledged % make test
rm -f coverage.out
bash hack/run-unit-tests.sh
# github.com/senthilrch/kube-fledged/cmd/controller/app [github.com/senthilrch/kube-fledged/cmd/controller/app.test]
cmd/controller/app/controller_test.go:75:29: not enough arguments in call to NewController
	have (kubernetes.Interface, versioned.Interface, string, "k8s.io/client-go/informers/core/v1".NodeInformer, "github.com/senthilrch/kube-fledged/pkg/client/informers/externalversions/kubefledged/v1alpha2".ImageCacheInformer, time.Duration, time.Duration, string, string, string)
	want (kubernetes.Interface, versioned.Interface, string, "k8s.io/client-go/informers/core/v1".NodeInformer, "github.com/senthilrch/kube-fledged/pkg/client/informers/externalversions/kubefledged/v1alpha2".ImageCacheInformer, time.Duration, time.Duration, string, string, string, string)
# github.com/senthilrch/kube-fledged/pkg/images [github.com/senthilrch/kube-fledged/pkg/images.test]
pkg/images/image_manager_test.go:55:46: not enough arguments in call to NewImageManager
	have (workqueue.RateLimitingInterface, workqueue.RateLimitingInterface, kubernetes.Interface, string, time.Duration, string, string, string)
	want (workqueue.RateLimitingInterface, workqueue.RateLimitingInterface, kubernetes.Interface, string, time.Duration, string, string, string, string)
pkg/images/image_manager_test.go:623:41: cannot use imageCacheName (type string) as type *v1alpha2.ImageCache in argument to imagemanager.updateImageCacheStatus
?   	github.com/senthilrch/kube-fledged/cmd/controller	[no test files]
FAIL	github.com/senthilrch/kube-fledged/cmd/controller/app [build failed]
?   	github.com/senthilrch/kube-fledged/cmd/webhook-server	[no test files]
?   	github.com/senthilrch/kube-fledged/cmd/webhook-server/app	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/apis/kubefledged	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/apis/kubefledged/v1alpha2	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/clientset/versioned	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/clientset/versioned/fake	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/clientset/versioned/scheme	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/clientset/versioned/typed/kubefledged/v1alpha2	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/clientset/versioned/typed/kubefledged/v1alpha2/fake	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/informers/externalversions	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/informers/externalversions/internalinterfaces	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/informers/externalversions/kubefledged	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/informers/externalversions/kubefledged/v1alpha2	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/client/listers/kubefledged/v1alpha2	[no test files]
FAIL	github.com/senthilrch/kube-fledged/pkg/images [build failed]
?   	github.com/senthilrch/kube-fledged/pkg/signals	[no test files]
?   	github.com/senthilrch/kube-fledged/pkg/webhook	[no test files]
FAIL
make: *** [test] Error 2
(⎈ |olah009:mxe-senthil)eechens@EMB-Q6BUMD6N kube-fledged %
@senthilrch
Copy link
Owner Author

SODACODE22: Raise PR against "develop" branch.

@aimanfatima
Copy link
Contributor

I want to give it a try. Can I work on this?

@senthilrch
Copy link
Owner Author

Yes of course. Please proceed

@senthilrch senthilrch added the enhancement Enhancement to existing feature label Mar 5, 2022
@senthilrch senthilrch added this to the v0.10.0 milestone Mar 7, 2022
@senthilrch senthilrch added SODAMED and removed SODALOW labels Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants