Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement request: avoid hardcode busybox init container #87

Closed
brainfair opened this issue Jul 29, 2021 · 1 comment
Closed

Enhancement request: avoid hardcode busybox init container #87

brainfair opened this issue Jul 29, 2021 · 1 comment
Assignees
@senthilrch
Labels
enhancement Enhancement to existing feature
Milestone
v0.8.1

Comments

@brainfair
Copy link

Avoid hardcode image

kube-fledged/pkg/images/image_helpers.go

Line 87 in 163cd80

Image: "busybox:1.29.2",

Proposal:
Set image for busybox via Env or args like --cri-client-image
@senthilrch senthilrch self-assigned this Jul 29, 2021
@senthilrch senthilrch added the enhancement Enhancement to existing feature label Jul 29, 2021
@senthilrch senthilrch added this to the v0.8.1 milestone Jul 29, 2021
@senthilrch
Copy link
Owner

@brainfair : thanks for noticing this. I'll have this implemented in upcoming v0.8.1 release

@senthilrch senthilrch mentioned this issue Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@senthilrch senthilrch

Labels
enhancement Enhancement to existing feature
Projects
None yet
Milestone
v0.8.1
Development

No branches or pull requests
2 participants
@brainfair @senthilrch