Add raster_shape param to rasterize pipeline #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it wouldn't hurt if you also added a test for the new validator. I am of the opinion that the util functions that have the potential to be used all over the place should probably be the most foolproof and tested. Other than that, it looks good. |
You are right and i was thinking of it. I'll make something happen. |
|
On second thought, i'll add tests in another MR, which will be dedicated to adding tests for all validator utilities we use. |
|
In that case, this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes another parameter of the rasterization task.
I also noticed a common pattern of validators, which i managed to extract into
ensure_exactly_one_definedfunction. It was tested locally.