Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello again and the idea of a lsio/beets based image #46

Closed
sentriz opened this issue Sep 6, 2021 · 0 comments
Closed

hello again and the idea of a lsio/beets based image #46

sentriz opened this issue Sep 6, 2021 · 0 comments

Comments

@sentriz
Copy link
Owner

sentriz commented Sep 6, 2021

hi @montchr, @w1ldg00se, and all

thank you for the PRs regarding basing the betanin image off of lsio/beets. I think it's a cool idea but I decided not to go for it for now. the reasons being

  • I have limited time to work on betanin and other projects these days with a busy full time job
  • my worry is that basing betanin off the lsio image could lead to the betanin build just breaking randomly like it loves to do already
  • I'm trying to make things as simple and reproducible as I can by pinning deps and having control over the base image
  • also I'm keeping in mind a future where betanin doesn't just shell out to betanin for music, but shells out to whatever media management cli tool you like

so instead I updated the image to build the likes of mp3val, mp3gain, chromaprint, lots of other stuff, by doing a docker multi stage build where those extra programs are built from APKBUILDs
(if I'm still missing some extra goodies that lsio comes with, please let me know)

on top of this

  • the new image is roughly the same size as lsio at about 200MB
  • no rustc
  • PID/GID are set by default
  • the docker volumes have changed to reflect this /root -> /b (also mentioned in readme)
  • IMO keeping it like this (just mounting a HOME directory) makes it easy to add other cli tool's config files

if you have any suggestions/questions/whatever please let me know 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant