feat: update kafka topic provisioning config #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimxogus
force-pushed
the
feat/kafka-topics
branch
from
f730dc1
to
1789911
Compare
|
@DanielMcAssey Thanks for the review, fixed all cleanup.policy configs |
|
@DanielMcAssey Can you review this? |
|
Looks good! @Mokto could this be merged? |
Mokto
reviewed
Apr 16, 2024
Mokto
approved these changes
Apr 17, 2024
Merged
This was referenced Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getsentry/snuba@9790335
getsentry/snuba@c1e30ef