Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter-ios finished #1

Open
SenyangZhuang opened this issue Feb 28, 2016 · 1 comment
Open

Twitter-ios finished #1

SenyangZhuang opened this issue Feb 28, 2016 · 1 comment

Comments

@SenyangZhuang
Copy link
Owner

Please Review. /cc @codepathreview
Thank you!

@minhchau273
Copy link

👍 Nice work! We added this homework so that you'll have the experience building an app that's more similar in complexity to a production app. The optional account switching feature is interesting because you have to think about how TwitterClient is caching the access token to make sure it works correctly for multiple accounts.

Some small comments:

  • Good job using NSNotificationCenter to show the new tweet immediately after posting the new one. You could use delegate to implement this feature. You will use delegate very frequently in the future.
  • You should validate the number of characters when composing new tweet.
  • Nice job with customizing the animation.

We have a detailed Project 5 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at universitysupport@codepath.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants