Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Adding Mac OS Support #10

Closed
fearganni opened this issue Jul 30, 2020 · 3 comments
Closed

Adding Mac OS Support #10

fearganni opened this issue Jul 30, 2020 · 3 comments
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@fearganni
Copy link
Contributor

I don't personally use MacOS, but it would be good for people who are making cross platform applications to have this feature, or something relatively close to the acrylic style.

@xanderfrangos
Copy link
Contributor

Actually, this module appears to be modeled after the existing "vibrancy" support in Electron: https://www.electronjs.org/docs/api/browser-window#winsetvibrancytype-macos

So MacOS support isn't needed.

@seo-rii
Copy link
Owner

seo-rii commented Jul 30, 2020

That's right, macOS supports the vibrancy option on the Electron itself. If this module is used in the same way as Windows in macOS, it is already processed to call the Electron built-in function without building the C module.

@seo-rii seo-rii closed this as completed Jul 30, 2020
@fearganni
Copy link
Contributor Author

you're right my mistake, i had a wee bit of a brain fart there

@seo-rii seo-rii added invalid This doesn't seem right wontfix This will not be worked on labels Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants