Reproducibility Feature by Adding python_version
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadrasabouri
added
bug
|
@sepandhaghighi please take a look at this PR. |
sepandhaghighi
requested changes
Jan 5, 2023
There was a problem hiding this comment.
@sadrasabouri Please take a look at my comments 💯
And also I suggest adding a test to overall_test.py and checking python_version, something like this:
>>> g.python_version == sys.version.split()[0]
True
samila/genimage.py
Outdated
| self.matplotlib_version), | ||
| VERSION_WARNING.format( | ||
| self.matplotlib_version, | ||
| get_python_version()), |
There was a problem hiding this comment.
I think it should be self.python_version
test/warning_test.py
Outdated
| @@ -13,12 +13,20 @@ | |||
| >>> g_.data2 == g.data2 | |||
| True | |||
| >>> with open('data.json', 'w') as fp: | |||
| ... json.dump({'data1': [0], 'data2': [0], 'python_version': '0'}, fp) | |||
| >>> with warns(RuntimeWarning, match=r"Source matplotlib version(.*) or Python version(.*) is different from yours, plots may be different."): | |||
| ... g = GenerativeImage(lambda x,y: 0, lambda x,y: 0, data=open('data.json', 'r')) | |||
There was a problem hiding this comment.
g = GenerativeImage(data=open('data.json', 'r'))
test/warning_test.py
Outdated
| ... json.dump({'data1': [0], 'data2': [0], 'matplotlib_version': '0'}, fp) | ||
| >>> with warns(RuntimeWarning, match=r"Source matplotlib version(.*) is different from yours, plots may be different."): | ||
| >>> with warns(RuntimeWarning, match=r"Source matplotlib version(.*) or Python version(.*) is different from yours, plots may be different."): | ||
| ... g = GenerativeImage(lambda x,y: 0, lambda x,y: 0, data=open('data.json', 'r')) |
There was a problem hiding this comment.
g = GenerativeImage(data=open('data.json', 'r'))
Codecov Report
@@ Coverage Diff @@
## dev #172 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 575 587 +12
Branches 88 90 +2
=========================================
+ Hits 575 587 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#171
What does this implement/fix? Explain your changes.
This PR added the
python_versionattributes to theGenerativeImageobject which is saved in both config and data files. At the same time, loading these files Python version would be checked to see if it's the same as the current Python version.