Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retype id for requests #18

Closed
LimpidCrypto opened this issue Aug 17, 2022 · 1 comment
Closed

Retype id for requests #18

LimpidCrypto opened this issue Aug 17, 2022 · 1 comment
Assignees
@LimpidCrypto
Labels
enhancement New feature or request

Comments

@LimpidCrypto
Copy link
Collaborator

Generally an id for requests can be typed as u32 or as str. Currently they are typed as u32. IMO we should type it as str. It would be more flexible. You could give the request an id that's really describing what it does while still being able to set it "1".
@LimpidCrypto LimpidCrypto self-assigned this Aug 17, 2022
@LimpidCrypto
Copy link
Collaborator Author

Will be fixed in next commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LimpidCrypto LimpidCrypto

Labels
enhancement New feature or request
Projects
xrpl-rust
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LimpidCrypto