Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do something about this skipped integration test that would fail on SQLite #10243

Open
papb opened this issue Dec 8, 2018 · 0 comments
Open

Do something about this skipped integration test that would fail on SQLite #10243

papb opened this issue Dec 8, 2018 · 0 comments
Labels
status: understood For issues. Applied when the issue is understood / reproducible. type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.

Comments

@papb
Copy link
Member

papb commented Dec 8, 2018 •
edited

This test on line 113 of dao-factory.test.js is skipped.

If unskipped, it fails on sqlite (and only on sqlite).

Why does this test exist? Is there any issue related to it? Should the test just be removed? Or should it be unskipped and something else fixed so that it passes?

There shouldn't be any skipped tests. Skipped tests should be a temporary thing, but this test was skipped by this commit almost five years ago...
@papb papb changed the title Do something about this skipped unit test that would fail on SQLite Do something about this skipped integration test that would fail on SQLite Dec 8, 2018
@stale stale bot added stale and removed stale labels Mar 30, 2019
@stale stale bot added stale and removed stale labels Jul 1, 2019
@sequelize sequelize deleted a comment from stale bot Jul 30, 2019
@sequelize sequelize deleted a comment from stale bot Jul 30, 2019
@papb papb self-assigned this Jul 30, 2019
@papb papb added status: understood For issues. Applied when the issue is understood / reproducible. type: other For issues and PRs. Something that does not fit in any of the other "type:" labels. labels Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: understood For issues. Applied when the issue is understood / reproducible. type: other For issues and PRs. Something that does not fit in any of the other "type:" labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@papb