bulkCreate with updateOnDuplicate do not work with individualHooks

[Crusader4Christ]

What are you doing?

Model.bulkCreate(data, {updateOnDuplicate:["value1","value2"], individualHooks:true})

What do you expect to happen?

INSERT INTO `model` (`id`,`value1`,`value2`) 
VALUES (1,'v1','v2') 
ON DUPLICATE KEY UPDATE `value1`=VALUES(`value1`), `value2`=VALUES(`value2`); 

What is actually happening?

INSERT INTO `model` (`id`,`value1`,`value2`) VALUES (1,'v1','v2')

Dialect: mysql
Dialect version: XXX
__Database version: 5.7
__Sequelize version: 4.42.0
__Tested with latest release:4.42.0

Bug is https://github.com/sequelize/sequelize/blob/v4/lib/model.js#L2406 modelInstance.save do not handle updateOnDuplicate.
It can be fixed if https://github.com/sequelize/sequelize/blob/v4/lib/query-interface.js#L896
will check updateOnDuplicate for mySQL and use upsertQuery in this case

[AndyBaird]

I am having a similar problem with getting the updateOnDuplicate option to work.

What are you doing?

[err, response] = await to(Lists.bulkCreate(req.body,{ updateOnDuplicate:['id','order'], }));

What do you expect to happen?

ON DUPLICATE KEY UPDATE should get appended but it does not, so the queries fail

What is actually happening?

Executing (default): INSERT INTO `lists` (`id`,`order`,`original`,`completed`,`archive`,`subheading`,`public`,`style`,`createdAt`,`updatedAt`,`hierarchyLevel`) VALUES (15,12,true,false,false,false,true,0,'2019-03-05 00:17:48','2019-03-05 00:17:48',1);`

[papb]

Tested with latest release:4.42.0

Can someone please test with the latest 5.x version?

[sushantdhiman]

This fails because save / create does not support updateOnDuplicate which is used when using individualHooks

const Sequelize = require('./index');
const sequelize = require('./test/support').createSequelizeInstance();
const Op = Sequelize.Op;

const Model = sequelize.define('Model', {
  name: Sequelize.STRING,
  company: {
    type: Sequelize.STRING,
    unique: true
  }
});

(async () => {
  await Model.sync({ force: true });

  await Model.bulkCreate([
    {
      name: 'abc',
      company: 'c1'
    },
    {
      name: 'xyz',
      company: 'c2'
    }
  ]);

  const result = await Model.bulkCreate([
    {
      name: 'cds',
      company: 'c1'
    },
    {
      name: 'xsyz',
      company: 'c2'
    }
  ], {
    updateOnDuplicate: ['name'],
    individualHooks: true
  });

  console.log(result);
})();

[anz-davar]

same issue with sequelize 5.15.1

[djustclean]

guys i am using bulkCreate at too many places. it works fine but thing is if query finds and unique key failure then it updates otherwise it creates. you should keep in mind about unique key to pass in you query like

const result = await Model.bulkCreate([
{
id: 1,
name: 'cds',
company: 'c1'
},
{
id: null,
name: 'xsyz',
company: 'c2'
}
], {
updateOnDuplicate: ['name'],
individualHooks: true
});

[djustclean]

so here id is primary key or unique if it exists then it will update otherwise it will create

[pushkar0108]

Do we have any update on this or some work around?

[aneeq-ur-rehman4]

This could have been the most awesome feature. But this bug is ruining it. A little attention to this issue will be appreciated. Regards.