Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeDefinition(Model): version is missing in the model definition #10641

Closed
eddiemonge opened this issue Mar 28, 2019 · 3 comments
Closed

TypeDefinition(Model): version is missing in the model definition #10641

eddiemonge opened this issue Mar 28, 2019 · 3 comments
Labels
released type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.

Comments

@eddiemonge
Copy link

@5 the TypeScript definition for model is missing the version attribute (which controls optimistic locking).
@sushantdhiman sushantdhiman added the type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. label Mar 29, 2019
@SimonSchick
Copy link
Contributor

Can you link the docs to that?

@SimonSchick SimonSchick mentioned this issue Apr 1, 2019
Merged
5 tasks
@sushantdhiman
Copy link
Contributor

🎉 This issue has been resolved in version 5.2.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eddiemonge
Copy link
Author

@SimonSchick This breaks Sequelize instances. I get:

Property 'models' does not exist on type 'Sequelize'. Did you mean 'model'?

After doing const db = new Sequelize({...}); db.models

Specifically the version?:... line. Removing that restores the type recognition for Models (but obviously removes the types for the version property.

Left this same comment in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eddiemonge @SimonSchick @sushantdhiman