Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V6: Removing support for NodeJS v6 #10821

Closed
SimonSchick opened this issue Apr 22, 2019 · 12 comments
Closed

V6: Removing support for NodeJS v6 #10821

SimonSchick opened this issue Apr 22, 2019 · 12 comments
Assignees
@janmeier @SimonSchick @sushantdhiman @eseliger
Labels
breaking change For issues and PRs. Changes that break compatibility and require a major version increment. type: refactor For issues and PRs. Things that improve the code readability, maintainability, testability, etc.
Milestone
v6

Comments

@SimonSchick
Copy link
Contributor

Node v6 is approaching the end of it's long term support window and will be end of life on 4/30.

We will no longer be supporting node v6 and you will not be able to use sequelize v6 in node v6 without the use of transpilers and polyfills.
@SimonSchick SimonSchick added breaking change For issues and PRs. Changes that break compatibility and require a major version increment. advisory labels Apr 22, 2019
@SimonSchick SimonSchick pinned this issue Apr 22, 2019
@SimonSchick
Copy link
Contributor Author

See related PR https://github.com/sequelize/sequelize/pull/10739/commits

@SimonSchick SimonSchick added this to the v6 milestone Apr 22, 2019
@janmeier
Copy link
Member

👍

@papb papb added type: refactor For issues and PRs. Things that improve the code readability, maintainability, testability, etc. status: wip For issues and PRs. Applied when the PR is not ready yet / when work to close the issue has started. and removed advisory labels Jul 30, 2019
@gabegorelick
Copy link
Contributor

Node 8 reaches end of life December 31, 2019. Should support for that be dropped too?

@papb
Copy link
Member

papb commented Oct 9, 2019

Hmmm, probably :)

@sushantdhiman
Copy link
Contributor

Supporting Node >= 10, #11580

@sushantdhiman sushantdhiman removed the status: wip For issues and PRs. Applied when the PR is not ready yet / when work to close the issue has started. label Oct 19, 2019
@sushantdhiman sushantdhiman unpinned this issue Dec 12, 2019
@harshdeep-jft
Copy link

I dont think sequelize supports node v18. Cannot lift the application with it, Its working on node v16 fine.

@WikiRik
Copy link
Member

WikiRik commented Sep 22, 2022

I dont think sequelize supports node v18. Cannot lift the application with it, Its working on node v16 fine.

What version of sequelize are you using? The latest v6 release should work with Node 18

@harshdeep-jft
Copy link

@WikiRik I am using Sequelize: 6.23.0 and tedious: 15.1.0 and mssql: 7.3.0

@harshdeep-jft
Copy link

@WikiRik I am using Sequelize: 6.23.0 and tedious: 15.1.0 and mssql: 7.3.0

It throws this error : ConnectionError [SequelizeConnectionError]: Failed to connect to 192.168.106.10:1433 - socket hang up at ConnectionManager.connect (/home/test project/node_modules/sequelize/lib/dialects/mssql/connection-manager.js:109:17)

@SimonSchick
Copy link
Contributor Author

Can you provide a min repro?

@harshdeep-jft
Copy link

Can you provide a min repro?

I just create an app with express-generator in node v18 and configured it with sequelize, that's all, can you try the same in your machine?

@WikiRik
Copy link
Member

WikiRik commented Sep 22, 2022

This might be due to the usage of tedious 15. v6 is still using 8.3.0 and hasn't updated yet. We've done some work on main for this, see #14784 #13961 and #13960
I'll look into backporting some of this over the next days

@jhon-jeeves jhon-jeeves mentioned this issue Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janmeier janmeier

@SimonSchick SimonSchick

@sushantdhiman sushantdhiman

@eseliger eseliger

Labels
breaking change For issues and PRs. Changes that break compatibility and require a major version increment. type: refactor For issues and PRs. Things that improve the code readability, maintainability, testability, etc.
Projects
None yet
Milestone
v6
Development

No branches or pull requests
8 participants
@gabegorelick @janmeier @SimonSchick @sushantdhiman @WikiRik @eseliger @papb @harshdeep-jft