Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pool): Fixes pooling when replication is being utilized. #11140

Merged

Conversation

mkaufmaner
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #11139

Copy link
Contributor

@sushantdhiman sushantdhiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Verified this issue is not present on v5 which does not try to pool error objects.

Some related issues

@sushantdhiman sushantdhiman merged commit a1ccf04 into sequelize:v4 Jul 2, 2019
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 4.44.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@achoppam
Copy link

achoppam commented Jul 3, 2019

From 4.44.1, I can see .git part of tar bundle.

Can we remove and release next version.

This is causing below issue
This issue happens 4.44.1

`

npm ERR! path /node_modules/sequelize
npm ERR! code EISGIT
npm ERR! git /node_modules/sequelize: Appears to be a git repo or submodule.
npm ERR! git /node_modules/sequelize
npm ERR! git Refusing to remove it. Update manually,
npm ERR! git or move it out of the way first.

npm ERR! A complete log of this run can be found in:
npm ERR! /users/asciuser/.npm/_logs/2019-07-03T00_32_38_362Z-debug.log
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants