queryInterface.renameColumn drop unique constraint in SQLite

[eugene-matvejev]

What are you doing?

demo:
https://github.com/eugene-matvejev/node-explorer/pull/10/files

# file 1
'use strict';
module.exports = {
    up: (queryInterface, Sequelize) => {
        return queryInterface.createTable('statuses', {
            id: {
                // type: DataTypes.UUID,
                type: Sequelize.INTEGER,
                primaryKey: true,
                autoIncrement: true,
            },
            name: {
                type: Sequelize.STRING,
                unique: true,
            },
            state: {
                type: Sequelize.INTEGER,
                allowNull: false,
                defaultValue: 0,
            },
            parent: {
                type: Sequelize.INTEGER
            },
        });
    },
    down: (queryInterface, Sequelize) => {
        return queryInterface.dropTable('statuses');
    }
};


# file 2
'use strict';

module.exports = {
    up: (queryInterface, Sequelize) => {
        return queryInterface.renameColumn('statuses', 'state', 'seq');
    },
    down: (queryInterface, Sequelize) => {
        return queryInterface.renameColumn('statuses', 'seq', 'state');
    }
};

To Reproduce
1 run migration in file 1 correct output

sqlite> .schema statuses
CREATE TABLE `statuses` (`id` INTEGER PRIMARY KEY AUTOINCREMENT, `name` VARCHAR(255) UNIQUE, `seq` INTEGER NOT NULL DEFAULT 0, `parent` INTEGER);

2 run migration in file 2, 'UNIQUE' constrain gone from name column

sqlite> .schema statuses
CREATE TABLE `statuses` (`id` INTEGER PRIMARY KEY, `name` VARCHAR(255), `parent` INTEGER, `seq` INTEGER NOT NULL DEFAULT '0');

What do you expect to happen?

state column to be renamed to seq, other columns shouldn't be affected

What is actually happening?

'UNIQUE' constrain gone from name column

see example above

Environment

Dialect:

• mysql
• postgres
• sqlite
• mssql
• any

Sequelize CLI [Node: 10.16.0, CLI: 5.5.0, ORM: 5.10.1]
Dialect library version: 5.10.1
Database version: 4.0.9
Sequelize version: 5.5.0
Node Version: 10.16.0
OS: MacOs
If TypeScript related: TypeScript version: n/a
Tested with latest release:

• No
• Yes, specify that version:

[eugene-matvejev]

very bad work around who is interested: https://github.com/eugene-matvejev/node-explorer/pull/12/files

[papb]

Can you please test this with another dialect? This is important to know whether the problem is dialect-specific or not.

You can instantiate a local postgres instance very easily:

1. Run a local postgres
   • On windows: PostgreSQLPortable_10.4.1.zip (no need to install, just unzip and run)
     • Run the .exe and then CREATE DATABASE testdb; (don't close the .exe)
   • On linux (with docker): docker pull postgres && docker run --rm --name pg -d -p 5432:5432 postgres
     • Run docker exec -t pg psql -U postgres -c 'CREATE DATABASE testdb;'
2. new Sequelize('postgres://postgres@localhost:5432/testdb')

[gilmrjc]

I can confirm this only happens on SQLite.

[github-actions]

This issue has been automatically marked as stale because it has been open for 7 days without activity. It will be closed if no further activity occurs. If this is still an issue, just leave a comment or remove the "stale" label. 🙂