model.save({ where })

[gabegorelick]

Is your feature request related to a problem? Please describe.
I want to save a model, but only if a condition still holds. An example of this would be versioning, which model.save already supports internally, but a where clause is more general.

Describe the solution you'd like
model.save({where})

Why should this be in Sequelize
model.save internally constructs a WHERE clause consisting of the model's primary key and, optionally, versioning. The ability to add to that is very useful.

Describe alternatives you've considered
Versioning is already supported by Sequelize, but it requires cooperation from the model (needs to have versioning enabled). It's also much more limited.

Model.update can be used, but requires manually adding the instance's primary key to the where clause:

Model.update({
  where: {
    id: instance.id,// need to make sure you set the primary key correctly!
    condition: ...
   }
});

Usage example

await model.destroy({force: false});
model.foo = 'bar';

// Only update if model is still deleted
await model.save({where: {deletedAt: model.deletedAt}});

Additional context
Would need to figure out what should happen if caller specified primary key in where. Should that override the primary key that model.save sets internally, or throw an error? Same for versioning.

[papb]

What is this "versioning" you are referring to?

[gabegorelick]

What is this "versioning" you are referring to?

https://sequelize.org/master/manual/models-definition.html#optimistic-locking

sequelize/lib/model.js

Lines 3828 to 3830 in c32ac01

	if (versionAttr) {
	values[versionFieldName] = parseInt(values[versionFieldName], 10) + 1;
	}

[github-actions]

This issue has been automatically marked as stale because it has been open for 7 days without activity. It will be closed if no further activity occurs. If this is still an issue, just leave a comment or remove the "stale" label. 🙂

[ephys]

This issue is strongly related to #16158, where we discussed making the method throw an OptimisticLockError (or similar) if the condition matched no records