fix(sequelize.col): associations #11419
Conversation
Enum doesn't escape values on "Create Table"
Sequelize.col doesn't support use of associations
|
Sorry for the previous test, it worked with my dialect (Postgres) |
|
Hello, thanks for the PR, I am under the impression this solves an existing issue, do you know which one? Also, to be honest I am surprised this little change you made solves it without breaking anything... Amazing! Can you explain how is it possible that your change does not break anything? |
papb
added
status: awaiting response
|
It's just by chance and I thought this change was logical compared to the associations between tables, that's all ^^" |
papb
added
status: awaiting maintainer
and removed
status: awaiting response
| }); | ||
| }).then(() => { | ||
| return Table1.findAll({ | ||
| raw: true, |
There was a problem hiding this comment.
Remove raw and assert on return value
sushantdhiman
added
status: awaiting response
Codecov Report
@@ Coverage Diff @@
## master #11419 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 94 94
Lines 9181 9181
=======================================
Hits 8838 8838
Misses 343 343
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 5.19.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Sequelize.col doesn't support use of associations