Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bulkupdate): pass correct type in options #11515

Merged
merged 1 commit into from Oct 7, 2019

Conversation

krazi3
Copy link
Contributor

@krazi3 krazi3 commented Oct 6, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #10625

Set type on options in query-interface bulkUpdate method.

@codecov
Copy link

codecov bot commented Oct 6, 2019

Codecov Report

Merging #11515 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11515      +/-   ##
==========================================
+ Coverage   96.26%   96.26%   +<.01%     
==========================================
  Files          94       94              
  Lines        9181     9182       +1     
==========================================
+ Hits         8838     8839       +1     
  Misses        343      343
Impacted Files Coverage Δ
lib/query-interface.js 92.19% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe2401...8f9c43f. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 3c8ca77 into sequelize:master Oct 7, 2019
@sushantdhiman
Copy link
Contributor

🎉 This PR is included in version 5.19.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queryInterface.bulkUpdate fails with MySQL
2 participants