Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I set queueLimit for MySQL pool? #11953

Open
2 of 7 tasks
sandinmyjoints opened this issue Feb 24, 2020 · 1 comment
Open
2 of 7 tasks

How can I set queueLimit for MySQL pool? #11953

sandinmyjoints opened this issue Feb 24, 2020 · 1 comment
Labels
type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.

Comments

@sandinmyjoints
Copy link
Contributor

Issue Description

  • node-mysql and mysql2 support a pool option called queueLimit which configures what to do with incoming requests when all connections in a pool are in use. How can I get similar behavior with sequelize?

What was unclear/insufficient/not covered in the documentation

  • after looking through the docs and code (of both sequelize and sequelize-pool), I can't tell if it's possible to set this option via sequelize or not, though I'm leaning towards not possible as it seems like pooling is all handled by sequelize-pool and I don't see any reference to a queue limit in there, only "If creating a new client would exceed the maximum, add the client to the wait list."
  • this seems suboptimal since if the rate of incoming requests exceeds the rate of responses, the wait list will grow until it causes problems
  • if there isn't a way to get this behavior with sequelize-pool, is it possible to opt out of sequelize-pool and use mysql2's pool instead?

Additional context

Issue Template Checklist

Is this issue dialect-specific?

  • No. This issue is relevant to Sequelize as a whole.
  • Yes. This issue only applies to the following dialect(s): XXX, YYY, ZZZ
  • I don't know.

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I don't know how to start, I would need guidance.
  • No, I don't have the time, although I believe I could do it if I had the time...
  • No, I don't have the time and I wouldn't even know how to start.
@sandinmyjoints sandinmyjoints added the type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. label Feb 24, 2020
@sandinmyjoints sandinmyjoints changed the title How can I set queueLimit for MySQL? How can I set queueLimit for MySQL pool? Feb 24, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

This issue has been automatically marked as stale because it has been open for 7 days without activity. It will be closed if no further activity occurs. If this is still an issue, just leave a comment or remove the "stale" label. 🙂

@github-actions github-actions bot added the stale label Nov 3, 2021
@WikiRik WikiRik removed the stale label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Development

No branches or pull requests

2 participants