Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed variable name to string in getters/setters documentation #12811

Closed
wants to merge 1 commit into from
Closed

Changed variable name to string in getters/setters documentation #12811

wants to merge 1 commit into from

Conversation

sliterok
Copy link
Contributor

@sliterok sliterok commented Nov 5, 2020

Shouldn't be username and password as variables, but 'username' and 'password' as strings

@sliterok
Changed variable name to string in getters/setters documentation
bc7ed22 
Shouldn't be username and password, but 'username' and 'password'
@codecov
Copy link

codecov bot commented Nov 5, 2020 •
edited

Codecov Report

Merging #12811 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12811   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          95       95           
  Lines        9261     9261           
  Branches       90       90           
=======================================
  Hits         8921     8921           
  Misses        323      323           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febc083...bc7ed22. Read the comment docs.

@djake
Copy link

djake commented Jan 12, 2021

There are similar changes in #12655.

@djake djake added the type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. label Jan 12, 2021
@papb
Copy link
Member

papb commented Mar 10, 2021

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

Recently, we decided to undo some large work that was done on the master branch. For this reason, we needed to "rework" your pull request targeting the new main branch. This was done by @shivamklr in #13074. For this reason, this PR will be closed when that one is merged. I will make sure you get credited for this work in that new commit, as you totally deserve.

@papb papb mentioned this pull request Mar 10, 2021
Merged
@papb papb closed this in #13074 Mar 10, 2021
papb pushed a commit that referenced this pull request Mar 10, 2021
@shivamklr @sliterok @williamgurzoni
docs(getters-setters-virtuals): fix typos (#13074 #12811 #12655)
801caa3 
Co-authored-by: sliterok <korobatov2011@yandex.ru>
Co-authored-by: William Gurzoni <william_luizat@hotmail.com>
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 6.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Mar 15, 2021
Closed
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Merged
This was referenced Mar 15, 2021
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Merged
danielschwartz pushed a commit to danielschwartz/sequelize that referenced this pull request Mar 15, 2021
@shivamklr @sliterok
@williamgurzoni @danielschwartz
docs(getters-setters-virtuals): fix typos (sequelize#13074 sequelize#…
b0394ee 
…12811 sequelize#12655)

Co-authored-by: sliterok <korobatov2011@yandex.ru>
Co-authored-by: William Gurzoni <william_luizat@hotmail.com>
This was referenced Mar 15, 2021
Closed
Closed
Merged
Merged
Closed
jctaveras pushed a commit to jctaveras/sequelize that referenced this pull request Mar 29, 2021
@shivamklr @sliterok @williamgurzoni
docs(getters-setters-virtuals): fix typos (sequelize#13074 sequelize#…
ff16266 
…12811 sequelize#12655)

Co-authored-by: sliterok <korobatov2011@yandex.ru>
Co-authored-by: William Gurzoni <william_luizat@hotmail.com>
@aryem aryem mentioned this pull request Aug 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sliterok @djake @papb