Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update external link to GeoJSON spec #12937

Closed
wants to merge 1 commit into from

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Jan 2, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

hi there! 馃憢
just an update for a stale link in the documentation.

old link: http://geojson.org/geojson-spec.html
Screen Shot 2021-01-01 at 7 57 14 PM
new link: https://tools.ietf.org/html/rfc7946

the current link is obsolete
@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #12937 (a8526bd) into master (6554992) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12937   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          95       95           
  Lines        9261     9261           
  Branches       90       90           
=======================================
  Hits         8921     8921           
  Misses        323      323           
  Partials       17       17           
Impacted Files Coverage 螖
src/data-types.js 91.31% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6554992...a8526bd. Read the comment docs.

@djake djake added the type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. label Jan 12, 2021
@papb
Copy link
Member

papb commented Mar 4, 2021

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

Recently, we decided to undo some large work that was done on the master branch. For this reason, we needed to "rework" your pull request targeting the new main branch. This was done by @shivamklr in #13067. For this reason, this PR will be closed when that one is merged. I will make sure you get credited for this work in that new commit, as you totally deserve.

papb pushed a commit that referenced this pull request Mar 4, 2021
Co-authored-by: john gravois <jagravois@gmail.com>
@papb papb closed this Mar 4, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
danielschwartz pushed a commit to danielschwartz/sequelize that referenced this pull request Mar 15, 2021
Co-authored-by: john gravois <jagravois@gmail.com>
jctaveras pushed a commit to jctaveras/sequelize that referenced this pull request Mar 29, 2021
Co-authored-by: john gravois <jagravois@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants