New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typo in documentation for polymorphic associations #13405
Conversation
Please amend your commit message to match the angular naming convention as per the contributing doc. You can do this via Something like this should work:
|
change juncion -> junction
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Yo! what do I do to get this merged? I don't see a way to request a review. |
It's already approved. Once someone with merge permission sees it, it should be merged. I don't know how long that'll take, but eventually it should get merged. |
🎉 This PR is included in version 6.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…quelize#13405) change juncion -> junction
juncion -> junction
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Fixed a typo which appears just below "The setup for this goes as follows:" which can be viewed using following link
https://sequelize.org/master/manual/polymorphic-associations.html#configuring-a-many-to-many-polymorphic-association