Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in documentation for polymorphic associations #13405

Merged
merged 3 commits into from Oct 9, 2021

Conversation

anujjoshi63
Copy link
Contributor

juncion -> junction

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixed a typo which appears just below "The setup for this goes as follows:" which can be viewed using following link
https://sequelize.org/master/manual/polymorphic-associations.html#configuring-a-many-to-many-polymorphic-association

@wbourne0
Copy link
Member

wbourne0 commented Aug 4, 2021

Please amend your commit message to match the angular naming convention as per the contributing doc.

You can do this via git commit --amend then git push --force.

Something like this should work:

fix(docs): fix typo in documentation for polymorphic associations

{more details}

@wbourne0 wbourne0 added status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. labels Aug 4, 2021
@github-actions github-actions bot removed the status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action label Aug 4, 2021
@anujjoshi63
Copy link
Contributor Author

Done!

@wbourne0 wbourne0 changed the title correct a typo fix(docs): fix typo in documentation for polymorphic associations Aug 5, 2021
Copy link
Member

@wbourne0 wbourne0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wbourne0 wbourne0 changed the title fix(docs): fix typo in documentation for polymorphic associations docs: fix typo in documentation for polymorphic associations Aug 5, 2021
@anujjoshi63
Copy link
Contributor Author

Yo! what do I do to get this merged? I don't see a way to request a review.

@wbourne0
Copy link
Member

wbourne0 commented Aug 24, 2021

Yo! what do I do to get this merged? I don't see a way to request a review.

It's already approved. Once someone with merge permission sees it, it should be merged. I don't know how long that'll take, but eventually it should get merged.

@wbourne0 wbourne0 merged commit bbf3d76 into sequelize:main Oct 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

🎉 This PR is included in version 6.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants