Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we continue the TypeScript migration in v6? #13806

Closed
1 task done
ephys opened this issue Dec 21, 2021 · 1 comment
Closed
1 task done

Should we continue the TypeScript migration in v6? #13806

ephys opened this issue Dec 21, 2021 · 1 comment
Labels

Comments

@ephys
Copy link
Member

ephys commented Dec 21, 2021

Issue Creation Checklist

Issue Description

We're getting issues from users that were using /lib about breaking changes in the last release:

I think the TypeScript migration is going to keep breaking internal things which could impact a lot of projects, because:

  • export default does not produce the same code as module.exports = (The workaround to which is weird).
  • Files move around, breaking imports.
  • Users accidentally importing from /types are going to have TS issues (not as bad).

I'm opening this issue to pick the path forward regarding the migration:

  • option 1: we consider changes in /lib to not be breaking changes because it's internal.
  • option 2: we postpone the migration to v7, where we'll also block importing /lib.
  • option 3: we continue migration in v6, but we try to keep /lib like it were.
@ephys
Copy link
Member Author

ephys commented Dec 21, 2021

Closing this, we already have a thread for this that I didn't notice 🤦‍♀️

@ephys ephys closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant