col references in scopes break when the model is included

[Fardenz]

Issue Creation Checklist

• I have read the contribution guidelines

Bug Description

SSCCE

Here is the link to the SSCCE for this issue: LINK-HERE

Alternative Link in my cloned repository

What do you expect to happen?

When having a sequelize scope and querying some entity, the include works as expected.

But when including that entity in another entity query, it fails because the reference to the first entity is not correct.

I expect this code to not throw an error and the check from line 72 to work.

Environment

• Sequelize version: 6.12.4
• Node.js version: v14.17.0

Bug Report Checklist

How does this problem relate to dialects?

• I think this problem happens regardless of the dialect.
• I think this problem happens only for the following dialect(s):
• I don't know, I was using PUT-YOUR-DIALECT-HERE, with connector library version XXX and database version XXX

Would you be willing to resolve this issue by submitting a Pull Request?

• Yes, I have the time and I know how to start.
• Yes, I have the time but I don't know how to start, I would need guidance.
• No, I don't have the time, although I believe I could do it if I had the time...
• No, I don't have the time and I wouldn't even know how to start.

[github-actions]

This issue has been automatically marked as stale because it has been open for 14 days without activity. It will be closed if no further activity occurs within the next 14 days. If this is still an issue, just leave a comment or remove the "stale" label. 🙂

[Fardenz]

This is still an issue for me. In this SSCCE you can see how just by importing another entity the query is malformed and crashes the program.

[ephys]

In your SSCCE, I think your on clause in your default scope should have been:

on: {
  'name2': { [Op.col]: 'foo.name2' }
}

otherwise you'll end up with bar.name2 = bar.name2

---

As for the actual issue. I think we could fix this in Model._validateIncludedElement + Model._injectScope: References to the scope owner's table could be transformed:

on: {
  'name2': { [Op.col]: 'foo.name2' }
}

would becomes

on: {
  'name2': { [Op.col]: 'bar.foo.name2' }
}