feat(postgres): support connectionTimeoutMillis dialectOption

[mmfKupl]

Pull Request Checklist

Please make sure to review and check all of these items:

• Have you added new tests to prevent regressions?
• Does yarn test or yarn test-DIALECT pass with this change (including linting)?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
• Did you update the typescript typings accordingly (if applicable)?
• Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
• Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Add support of "connectionTimeoutMillis" option for PostgreSQL dialect
https://node-postgres.com/api/client

[sdepold]

I think this should target main and we cherry pick it over. How confident are we that the camel case notation is correct where all the other props seem to prefer underscores.

To be investigated:

Do we have tests for that?
Do we document the supported options somewhere?
Is there actually any reason to not just forward all passes option to the driver in question? Why would sequelize do a sanity check in the first place?
Can we make use of the drivers typescript annotations to prevent people passing rubbish?

[sdepold]

Thanks for your pr :)

[ephys]

I agree with the sanity check being redundant. I think dialectOptions should be passed to the dialect as-is

[sdepold]

I agree with the sanity check being redundant. I think dialectOptions should be passed to the dialect as-is

@mmfKupl Interested in doing that change?

[mmfKupl]

I agree with the sanity check being redundant. I think dialectOptions should be passed to the dialect as-is

@mmfKupl Interested in doing that change?

Yes. I will change my pr with this comment

[schmod]

think dialectOptions should be passed to the dialect as-is

This could be confusing, because we actually have at least one sequelize-specific parameter in dialectOptions: clientMinMessages. As long as node-postgres never adds a parameter of the same name, I suppose we could just pluck that off and pass the rest over? Or just hand the whole thing over with the extra parameter intact?

[ephys]

clientMinMessages, odbcConnectionString authentication, debug, and prependSearchPath are the 5 dialect options I could find that are handled by Sequelize

I think we'll leave things as they are right now and we'll revisit what dialectOptions is meant to be in Sequelize 8 when we split the dialects to their own packages. It should allow us to strictly type dialectOptions based on the dialect.

[github-actions]

🎉 This PR is included in version 6.37.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀